Improve error message with id of the canvas#10495
Merged
etimberg merged 2 commits intochartjs:masterfrom Jul 20, 2022
Merged
Conversation
etimberg
approved these changes
Jul 20, 2022
kurkle
approved these changes
Jul 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed on some stack issues people tried to call Chart.getChart('0').destroy() but that does not work since it does not return the chart instance. So added the canvas ID to hopefully make it so people don't get that error anymore.
https://codepen.io/leelenaleee/pen/oNEPGbP