feat: allow escaping dot in parsing axis keys#10501
Closed
thabarbados wants to merge 1 commit intochartjs:masterfrom
Closed
feat: allow escaping dot in parsing axis keys#10501thabarbados wants to merge 1 commit intochartjs:masterfrom
thabarbados wants to merge 1 commit intochartjs:masterfrom
Conversation
Member
|
This could have performance impact. |
Contributor
Author
|
@kurkle How can I check it? |
LeeLenaleee
reviewed
Jul 22, 2022
| When using keys of the form `foo.bar`, you can allow for escaping dot symbol and add a double slash before the dot. | ||
|
|
||
| ```javascript | ||
| type: 'doughnut', |
Collaborator
There was a problem hiding this comment.
Change this to line or bar since the doughnut chart does not use xAxisKey and yAxisKey
| }] | ||
| }, | ||
| options: { | ||
| parsing: { xAxisKey: "data\\.key", yAxisKey: "data\\.value"}, |
Collaborator
There was a problem hiding this comment.
Put the xAxisKey and yAxisKey both on a separate line to match other code block
Member
You need a large dataset and parsing enabled. Then test with / without the patch. I did some tests (3 datasets with 55550 datapoints each) : |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow escaping '.' in parsing *AxisKey #10348
You can check the build with changes here