fix: calc visible points on update #10467#10523
Merged
etimberg merged 1 commit intochartjs:masterfrom Jul 28, 2022
TrigenSoftware:fix-10467
Merged
fix: calc visible points on update #10467#10523etimberg merged 1 commit intochartjs:masterfrom TrigenSoftware:fix-10467
etimberg merged 1 commit intochartjs:masterfrom
TrigenSoftware:fix-10467
Conversation
etimberg
previously approved these changes
Jul 27, 2022
LeeLenaleee
previously approved these changes
Jul 27, 2022
kurkle
reviewed
Jul 28, 2022
Member
kurkle
left a comment
There was a problem hiding this comment.
What breaks if it always uses <=?
My thought was to make sure the .hi is always the last (and .lo first) in case there are multiple equal values.
That said, I do not know if it would be easy to do or if it would result in slower code.
Would you be willing to ty it out?
Collaborator
Author
Tests are failing Details |
kurkle
approved these changes
Jul 28, 2022
LeeLenaleee
approved these changes
Jul 28, 2022
etimberg
approved these changes
Jul 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #10467