fix: decimation plugin data not writeable after clean #11045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurkle
reviewed
Jan 10, 2023
etimberg
approved these changes
Jan 10, 2023
kurkle
approved these changes
Jan 11, 2023
|
Wondering if its possible to store the original definition and use that when restoring. In case its read only initially, for example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the decimation plugin and changing data it will throw
Uncaught TypeError: Cannot assign to read only property 'data' of object '#<Object>', because thedataproperty is not writeable anymore after cleanup.Changing from
defineProperty(defaultwritablefalse) to normal property assignment, will fix the issue.