Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export explicitly the plugin options definition which is augmented by plugins implementation #11309

Merged
merged 1 commit into from
May 25, 2023

Conversation

stockiNail
Copy link
Contributor

Fix #11288

The following table is showing the augmented definitions, performed by plugins in chartjs org (in addition to PluginOptionsByType) which are fixed by this PR:

Plugin Augmented Definitions
annotation ElementOptionsByType
datalabels ChartDatasetProperties
deferred -
zoom UpdateModeEnum

This PR is also reverting PR #11244

@etimberg etimberg added this to the Version 4.3.1 milestone May 25, 2023
@etimberg etimberg merged commit abbd5a7 into chartjs:master May 25, 2023
@stockiNail stockiNail deleted the fixTSdefExport branch May 25, 2023 18:10
@LeeLenaleee LeeLenaleee added the type: types Typescript type changes label May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: types Typescript type changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues importing plugins and TS module augmentation
3 participants