-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix time series scale to have each data point is spread equidistant #11388
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think this makes sense and seems to more closely match the old behaviour. @LeeLenaleee @kurkle do you recall how the original v3 logic came to be?
No, don't know. That happend before I got involved |
I do not recall. I did not dig to see if this new behaviour can happen with |
@kurkle the timeseries scale is extending the time scale. THis PR impl overrides the See time scale source: buildTicks() {
const options = this.options;
const timeOpts = options.time;
const tickOpts = options.ticks;
const timestamps = tickOpts.source === 'labels' ? this.getLabelTimestamps() : this._generate(); |
@etimberg @kurkle @LeeLenaleee I think I should be done.
This is partially true. Timeseries scale does not support all options, for instance |
Lets leave the docs for another PR, as that will be rather slow to audit each setting |
Fix #11371
TODO