Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix #10896 - Changed 'r' to optional for BubbleChart #11662

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

waszkiewiczja
Copy link
Contributor

This is a change to BubbleDataPoint to set r as an optional parameter.

As mentioned here #11602 BubbleChart works without this parameter because it takes the default r value from the dataset property radius and it default value is 3.

TS screams: Property 'r' is missing in type '{ x: number; y: number; }' but required in type 'BubbleDataPoint'. but it doesn't affect the chart.

@etimberg etimberg added this to the Version 4.5.0 milestone Feb 11, 2024
@etimberg etimberg added the type: types Typescript type changes label Feb 11, 2024
@etimberg etimberg merged commit caa56ce into chartjs:master Feb 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: types Typescript type changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants