-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not attempt to clear canvas if one does not exist #11764
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAcodedBEAT
force-pushed
the
getcontext-on-non-null
branch
from
May 7, 2024 22:30
02d4151
to
6666cbd
Compare
etimberg
previously approved these changes
May 7, 2024
LeeLenaleee
reviewed
May 10, 2024
DAcodedBEAT
force-pushed
the
getcontext-on-non-null
branch
from
May 13, 2024 14:33
6666cbd
to
e1d670d
Compare
LeeLenaleee
reviewed
May 13, 2024
LeeLenaleee
reviewed
May 16, 2024
LeeLenaleee
approved these changes
May 16, 2024
Thanks @LeeLenaleee , do you have an approximation for 4.5.0 being released? |
etimberg
approved these changes
May 17, 2024
I think we might be able to do a 4.4.3 release since there are only bug fixes soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected behavior
clearCanvas()
fromhelpers.canvas.ts
should only callgetContext()
on valid truth-yctx
values.Current behavior
Closes #11743
Reproducible sample
#11743
Optional extra steps/info to reproduce
No response
Context
.
chart.js version
4.4.2
Browser name and version
experienced on multiple browsers
Link to your project
No response