[fix] #12048 - Add selfJoin option for doughnut graphs #12054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12048
I have created an option called ArcOptions.selfJoin for doughnut and pie graphs. This option is false as default but when set to true, it will allow datasets that take up 100% of the graph to self join. This effect is only visible when border is activated and removes the separation line between what is effectively the same arc. To achieve this effect I used some cropping similar to how border align inner is implemented.
What it looks like
Tests
I have created 2 new tests for this new feature.
Known limitations
It is not obvious how to smoothly animate this joining when the graph uses border radius, inner border align or border join style miter. Those are not supported.