Rewrite the clone and merge helpers #4422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbrunel
force-pushed
the
helpers-merge
branch
from
9569b81
to
13494b3
Compare
etimberg
approved these changes
Jun 25, 2017
| // Type changed. Bring in the new defaults before we bring in valueObj so that valueObj can override the correct scale defaults | ||
| base[key][index] = helpers.configMerge(base[key][index], axisDefaults, valueObj); | ||
|
|
||
| helpers.scaleMerge = function(/* objects ... */) { |
There was a problem hiding this comment.
can't wait until v3 when this goes away since everything has a key
The `clone` method now accepts any type of input but also recursively perform a deep copy of the array items. Rewrite the `configMerge` and `scaleMerge` helpers which now rely on a new generic and customizable `merge` method, that one accepts a target object in which multiple sources are deep copied. Note that the target (first argument) is not cloned and will be modified after calling `merge(target, sources)`. Add a `mergeIf` helper which merge the source properties only if they do not exist in the target object.
simonbrunel
force-pushed
the
helpers-merge
branch
from
13494b3
to
ad4cf24
Compare
etimberg
approved these changes
Jul 1, 2017
yofreke
pushed a commit
to yofreke/Chart.js
that referenced
this pull request
Dec 30, 2017
The `clone` method now accepts any type of input but also recursively perform a deep copy of the array items. Rewrite the `configMerge` and `scaleMerge` helpers which now rely on a new generic and customizable `merge` method, that one accepts a target object in which multiple sources are deep copied. Note that the target (first argument) is not cloned and will be modified after calling `merge(target, sources)`. Add a `mergeIf` helper which merge the source properties only if they do not exist in the target object.
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
The `clone` method now accepts any type of input but also recursively perform a deep copy of the array items. Rewrite the `configMerge` and `scaleMerge` helpers which now rely on a new generic and customizable `merge` method, that one accepts a target object in which multiple sources are deep copied. Note that the target (first argument) is not cloned and will be modified after calling `merge(target, sources)`. Add a `mergeIf` helper which merge the source properties only if they do not exist in the target object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
clonemethod now accepts any type of input but also recursively perform a deep copy of the array items. Rewrite theconfigMergeandscaleMergehelpers which now rely on a new generic and customizablemergemethod, that one accepts a target object in which multiple sources are deep copied. Note that the target (first argument) is not cloned and will be modified after callingmerge(target, sources). Add amergeIfhelper which merge the source properties only if they do not exist in the target object.@chartjs/maintainers please review this PR carefully since it impacts the whole config process :)