Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of null labels #4795

Merged
merged 1 commit into from
Sep 29, 2017
Merged

Fix handling of null labels #4795

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/core.scale.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,7 +662,7 @@ module.exports = function(Chart) {

// Since we always show the last tick,we need may need to hide the last shown one before
shouldSkip = (skipRatio > 1 && i % skipRatio > 0) || (i % skipRatio === 0 && i + skipRatio >= tickCount);
if (shouldSkip && i !== tickCount - 1 || helpers.isNullOrUndef(tick.label)) {
if (shouldSkip && i !== tickCount - 1) {
// leave tick in place but make sure it's not displayed (#4635)
delete tick.label;
}
Expand Down Expand Up @@ -712,7 +712,7 @@ module.exports = function(Chart) {

helpers.each(ticks, function(tick, index) {
// autoskipper skipped this tick (#4635)
if (tick.label === undefined) {
if (helpers.isNullOrUndef(tick.label)) {
return;
}

Expand Down