Don't draw tick across axis/border #5178
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current version of chartjs, drawing ticks overlaps the tick line with the border or axis line, making those intersections darker. This PR takes that into account when drawing ticks or borders and offsets them appropriately.
Before:
https://codepen.io/anon/pen/dJLaje
I know it's small but you can probably see the darker pixel where the tick overlaps with the border.
After:
As you can see, no dark pixel!
In the future, I suggest spending even more time keeping lines from overlapping, even when gridlines intersect. This work is a small step in that direction.