Bugfix: Improve polyfill function of log10 to return whole powers of 10 #5275
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
helpers.log10
polyfill function doesn't return precise integer values for all whole powers of 10.This can cause an infinite loop as issued in #5264
The proposed PR uses a multiplication with
Math.LOG10E
instead of a division byMath.LN10
. This improves the accuracy, however as is shown in the table below, not all computed powers are correct, thus leading to the extra check, which is slower, but more accurate.