-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make bar styling options scriptable #5780
Conversation
About the CodeClimate issue, I'm going to see how to refactor it when introducing scriptable options for the line chart, which is a bit different because of the inconsistent option naming between the dataset and the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. I think there's one unused variable, but otherwise feel free to merge
The bar `backgroundColor`, `borderColor`, `borderWidth` and `borderSkipped` options are now scriptable (unit tests, docs and a basic sample). Also fix the gulp task that generates the documentation on Windows.
dd33a8e
to
431709a
Compare
@benmccann @etimberg I merged this one because you previously approved it (I just rebased since and addressed @benmccann comment). |
The bar `backgroundColor`, `borderColor`, `borderWidth` and `borderSkipped` options are now scriptable (unit tests, docs and a basic sample). Also fix the gulp task that generates the documentation on Windows.
The bar
backgroundColor
,borderColor
,borderWidth
andborderSkipped
options are now scriptable (unit tests, docs and a basic sample). Also fix the gulp task that generates the documentation on Windows.For example:
Fixes #5302