-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from gitbook to vuepress #5847
Conversation
0c03651
to
75b1c0a
Compare
bcb5c88
to
f55cbe3
Compare
How does it change the look of docs? |
Not much. It looks pretty similar. The main motivation is that gitbook no longer maintains their open source project and have moved on to supporting only their commercial service. There's no way to get bug fixes, security fixes, etc. for gitbook anymore |
I thought I commented this PR but apparently not. These changes break our CD because vuepress doesn't support to be deployed in a sub-folder. I figured out that issue when I started migrating this repo to vuepress a bit after do the same for the datalabels plugin. So we need to wait vuejs/vuepress#796 to be fixed first. |
Hmm. It's not clear to me that it's something they plan to fix. It seems like the recommendation is to use a static server: vuejs/vuepress#575 (comment). Would it be an option to deploy a static server to our production environment? |
Actually, maybe this will be implemented soonish. See vuejs/vuepress#796 (comment) |
I'm going to close this for now until vuepress is updated with the proper support |
Interestingly its still not fixed, but we have migrated to vuepress. |
Good job! The issue was mainly because of the |
Just FYI, we did not migrate to Vurpress, but rather to Docusaurus (React version of it) |
We actually did migrated from docusaurus to vuepress. Just migrated the samples too! |
Oh, interesting. Any reason for the migration? |
@benmccann mostly because of the great work @simonbrunel did with vuepress-theme-chartjs including amazing chart-editor component. |
Could also be because |
@simonbrunel good finding, I thought it would still be versioned. Needs to be fixed. |
We can look at doing that. It likely requires running |
This fixes the remaining security vulnerabilities in our dependencies