-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supply docs for barThickness #5854
Supply docs for barThickness #5854
Conversation
docs/charts/bar.md
Outdated
@@ -139,6 +139,16 @@ The bar chart defines the following configuration options. These options are mer | |||
| `gridLines.offsetGridLines` | `Boolean` | `true` | If true, the bars for a particular data point fall between the grid lines. The grid line will move to the left by one half of the tick interval. If false, the grid line will go right down the middle of the bars. [more...](#offsetgridlines) | |||
|
|||
### barThickness | |||
This option needs to be configured on x axis in scales property. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to make this align with the docs for offsetGridLines
. That means both that we should match the language (i.e. "This setting applies to the axis configuration.") and indentation (i.e. use 4-space indenting for the code sample)
@jedrekdomanski I'm pretty sure that all options listed in the "Common Configuration" belong to the
@etimberg @benmccann can you confirm? If so, instead of duplicating
What do you think? |
If this is the case then yes, we should change that, although I am not an expert of Chart.js so I don't feel in a position to verify that. @etimberg @benmccann Can you confirm it? |
I believe these are all scale options, but I only skimmed the code |
@jedrekdomanski I think you can go ahead and fix the whole section instead. |
- barThickness and other options no longer belong to `global` options, they now belong to `scale` options - example of usage of options provided in the table in the description
@jedrekdomanski should we also remove the similar part from
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jedrekdomanski
Add docs for barThickness option in Bar chart
Fixes #5853