Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gaps on the left and right when the axis offset is set to true #5884

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

nagix
Copy link
Contributor

@nagix nagix commented Dec 4, 2018

When the offset axis option is set to true, extra margins are added to the left and right edges depending on the tick label widths. This PR removes them by taking into account the tick offsets from the edges.

Version 2.7.3: https://jsfiddle.net/nagix/jwnkbf84/
screen shot 2018-12-05 at 1 16 39 am

This PR: https://jsfiddle.net/nagix/qz0vyed8/
screen shot 2018-12-05 at 1 27 06 am

Fixes #5818

@simonbrunel simonbrunel added this to the Version 2.8 milestone Dec 5, 2018
@simonbrunel simonbrunel merged commit 7c45fda into chartjs:master Dec 5, 2018
@simonbrunel
Copy link
Member

Thanks @nagix

@simonbrunel
Copy link
Member

Are you sure that #5818 is fixed by this PR?

@nagix
Copy link
Contributor Author

nagix commented Dec 5, 2018

I verified both #5818 and #5888 as fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants