-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(re)allow modifying ticks in afterBuildTicks #5913
Conversation
I'm not sure why I didn't think about that solution when refactoring this part of the scales, maybe because I was planning to deprecate all those callbacks. Anyway, looks like a good solution for now :) To get the same results as #4749 (
It's already public via @kurkle can you add a unit test? |
3ed0c88
to
5ee394f
Compare
@kurkle this PR will need to be rebased as well |
…/EGKWgM?editors=0010
A workaround proposal to regain lost functionality.
The 'internal' tick objects are exposed, but I only see it as a bonus for custom axis types.
Closes #4749
https://codepen.io/kurkle/pen/EGKWgM?editors=0010