Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup scales export for better import strategy #5953

Merged
merged 7 commits into from
Jan 5, 2019

Conversation

simonbrunel
Copy link
Member

Scales now export a function responsible to register the scale class and associated defaults while the definition has been moved outside the exported function.

Relates #4478
Closes #5941

Scales now export a function responsible to register the scale class and associated defaults while the definition has been moved outside the exported function.
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cant fully review on mobile, whitespace ignoring setting is not obeyed on larger diffs. Will do full review later.

src/scales/scale.logarithmic.js Outdated Show resolved Hide resolved
src/scales/index.js Outdated Show resolved Hide resolved
benmccann
benmccann previously approved these changes Jan 4, 2019
src/chart.js Outdated
@@ -17,6 +17,7 @@ Chart.Element = require('./core/core.element');
Chart.elements = require('./elements/index');
Chart.Interaction = require('./core/core.interaction');
Chart.layouts = require('./core/core.layouts');
Chart.LinearScaleBase = require('./scales/scale.linearbase');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a comment to remove this at v3 since it should be internal only?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

@etimberg etimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment. Looks good

Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to look hard, but found eventually a line to comment on 😈

src/chart.js Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants