Make the main controller importable #5969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbrunel
force-pushed
the
chore/importable-main-controller
branch
from
f86a114
to
6244a61
Compare
Merge `core/core.js` in `core/core.controller.js`, split defaults options next to their associated code and deprecate `Chart.type` (not sure what it was for).
simonbrunel
force-pushed
the
chore/importable-main-controller
branch
from
6244a61
to
953000a
Compare
benmccann
previously approved these changes
Jan 8, 2019
etimberg
previously approved these changes
Jan 9, 2019
| * for backward compatibility. Though, it can still be useful for plugins that | ||
| * would need to work on multiple charts?! | ||
| */ | ||
| Chart.instances = {}; |
There was a problem hiding this comment.
Yeah, this is helpful for iterating all charts on a page. It has been recommended in some cases
Is there a alternative way to enumerate all registered chart types? |
kurkle
previously approved these changes
Jan 9, 2019
simonbrunel
dismissed stale reviews from kurkle, etimberg, and benmccann
via
40f371f
|
@kurkle I removed the unused local |
etimberg
approved these changes
Jan 9, 2019
9 tasks
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Merge `core/core.js` in `core/core.controller.js`, split default options next to their associated code and deprecate `Chart.types` (not sure what it was for).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge
core/core.jsincore/core.controller.js, split defaults options next to their associated code and deprecateChart.types(not sure what it was for).This is part of #4478, will work on helpers next.