Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix randomly failing tooltip test #6061

Merged
merged 1 commit into from
Feb 10, 2019
Merged

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Feb 10, 2019

Use utility to trigger the event in the center of element rather than x/y -based coordinates (its the edge for rectangles)

@simonbrunel simonbrunel merged commit 409fdde into chartjs:master Feb 10, 2019
var point = meta.data[pointIndex];
var node = chart.canvas;
var rect = node.getBoundingClientRect();
var evt = new MouseEvent('mousemove', {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of other places in this file where we're creating a new MouseEvent instead of calling triggerMouseEvent. Do they need to be updated as well?

janelledement pushed a commit to janelledement/Chart.js that referenced this pull request Feb 10, 2019
Use utility to trigger the event in the center of element rather than x/y -based coordinates (its the edge for rectangles)
jonrimmer pushed a commit to jonrimmer/Chart.js that referenced this pull request Feb 14, 2019
Use utility to trigger the event in the center of element rather than x/y -based coordinates (its the edge for rectangles)
@kurkle kurkle deleted the tooltip-tests branch May 5, 2019 06:46
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
Use utility to trigger the event in the center of element rather than x/y -based coordinates (its the edge for rectangles)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants