Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to helpers.almostWhole #6120

Merged
merged 1 commit into from
Mar 19, 2019

Conversation

benmccann
Copy link
Contributor

This is the agreed upon parts of #5992. I'm going to close that PR for the time being to keep the review queue clear until we have an agreed upon path forward

kurkle
kurkle previously approved these changes Mar 10, 2019
nagix
nagix previously approved these changes Mar 11, 2019
@simonbrunel simonbrunel added this to the Version 2.9 milestone Mar 12, 2019
@simonbrunel
Copy link
Member

@benmccann can you resolve conflicts then we can merge?

@benmccann
Copy link
Contributor Author

@simonbrunel I've rebased this PR. Thanks for the review

@simonbrunel simonbrunel merged commit 4941aa0 into chartjs:master Mar 19, 2019
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants