Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cubicInterpolationMode and changed fill enum #6132

Merged
merged 10 commits into from
Apr 8, 2019
Merged

Added cubicInterpolationMode and changed fill enum #6132

merged 10 commits into from
Apr 8, 2019

Conversation

stockiNail
Copy link
Contributor

Added cubicInterpolationMode and changed fill enum

Added cubicInterpolationMode and changed fill enum
etimberg
etimberg previously approved these changes Mar 13, 2019
docs/configuration/elements.md Outdated Show resolved Hide resolved
etimberg
etimberg previously approved these changes Mar 13, 2019
Change the default value for cubicInterpolationMode from an empty string to 'default'.
@benmccann
Copy link
Contributor

@stockiNail this PR will need to be rebased

@stockiNail
Copy link
Contributor Author

rebased and commited

simonbrunel
simonbrunel previously approved these changes Apr 1, 2019
docs/charts/line.md Outdated Show resolved Hide resolved
etimberg
etimberg previously approved these changes Apr 1, 2019
@stockiNail stockiNail dismissed stale reviews from etimberg and simonbrunel via 8f64bf6 April 2, 2019 07:36
docs/charts/line.md Outdated Show resolved Hide resolved
docs/configuration/elements.md Outdated Show resolved Hide resolved
Copy link
Contributor

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all your patience on this one

@stockiNail
Copy link
Contributor Author

Thanks for all your patience on this one

@benmccann no problem at all. Being developer, I love coding (coding is art) but I love a little bit less document..
Having a project which wraps Chart.js, I try to read carefully the documentation to provide all functionalities.
Let me use this thread to add a couple of other items which, in my opinion, we should work on:

  • Controller: reading doc, it's not clear which data structure new controller should prepare. The methods documentation is missing, the methods needed to create data (or other) structure. To create a controller you should go to have a look to other implementation. The example in documentation is the simplest one.
  • New Axis: see above thought about Controller.
  • Default values: I have the feeling there are some other unclear defaults (as I wrote label of dataset on different charts)
  • Charts methods: isDatasetVisible() is not documented but it's very important due to the usage of hidden property is deprecated

GREAT LIBRARY! THANKS!

exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants