Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize angle for index in radialLinear scale #6177

Merged
merged 2 commits into from
Apr 2, 2019

Conversation

nagix
Copy link
Contributor

@nagix nagix commented Apr 1, 2019

getIndexAngle returns a normalized angle value so that it stays between 0 and PI * 2. For the unit tests, support for textAlign property is added in the mock context.

Master: https://jsfiddle.net/nagix/gynkp7ec/
Screen Shot 2019-04-02 at 1 04 44 AM

This PR: https://jsfiddle.net/nagix/ef7r0w8h/
Screen Shot 2019-04-02 at 1 07 45 AM

Fixes #6160

@simonbrunel simonbrunel added this to the Version 2.9 milestone Apr 2, 2019
@simonbrunel simonbrunel merged commit c457b50 into chartjs:master Apr 2, 2019
@simonbrunel
Copy link
Member

Thanks @nagix

@nagix nagix deleted the issue-6177 branch April 2, 2019 09:27
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants