Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the appropriate time format for auto tick generation #6182

Merged
merged 2 commits into from
Apr 26, 2019

Conversation

nagix
Copy link
Contributor

@nagix nagix commented Apr 4, 2019

The label width is currently calculated using time.displayFormats.millisecond regardless of time.unit. This PR uses the appropriate time format for auto tick generation if time.unit is specified.

Master: https://jsfiddle.net/nagix/6fjh43xy/
Screen Shot 2019-04-04 at 11 01 45 PM

This PR: https://jsfiddle.net/nagix/hfopn34g/
Screen Shot 2019-04-04 at 11 02 23 PM

Fixes #4411

benmccann
benmccann previously approved these changes Apr 4, 2019
kurkle
kurkle previously approved these changes Apr 15, 2019
etimberg
etimberg previously approved these changes Apr 15, 2019
Copy link
Member

@etimberg etimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth it to have a test for this?

@simonbrunel simonbrunel added this to the Version 2.9 milestone Apr 18, 2019
simonbrunel
simonbrunel previously approved these changes Apr 18, 2019
Copy link
Member

@simonbrunel simonbrunel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think a regression test would be useful as @etimberg suggested.

@nagix nagix dismissed stale reviews from simonbrunel, etimberg, kurkle, and benmccann via da2ef6d April 24, 2019 08:54
@nagix nagix force-pushed the issue-6182 branch 2 times, most recently from da2ef6d to 8a03ea0 Compare April 24, 2019 08:59
@nagix
Copy link
Contributor Author

nagix commented Apr 24, 2019

A regression test was added.

exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Time scale skipping values in 2.6
5 participants