Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests and a sample for radar scriptable line options #6263

Merged
merged 2 commits into from
May 21, 2019

Conversation

nagix
Copy link
Contributor

@nagix nagix commented May 11, 2019

#5621 added support for line scriptable options for the radar chart, but unit tests were missing. This PR adds tests and updates the radar chart sample.

Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find anything wrong, but didn't go through every thing yet.

Copy link
Member

@simonbrunel simonbrunel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nagix for this update, just a minor comment to make the image diff more robust in some cases.

fill: false
},
point: {
borderColor: function(ctx) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably set a higher border width on all these pointBorderColor tests to make sure the image diff will fail in case of a wrong color.

@nagix
Copy link
Contributor Author

nagix commented May 20, 2019

Updated image tests based on the review comment and #6269.

kurkle
kurkle previously approved these changes May 20, 2019
@nagix
Copy link
Contributor Author

nagix commented May 21, 2019

Rebased and updated image tests based on #6281 and #6282.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants