Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dataset metadata when axisID changes #6321

Merged
merged 1 commit into from
Jun 14, 2019
Merged

Update dataset metadata when axisID changes #6321

merged 1 commit into from
Jun 14, 2019

Conversation

nagix
Copy link
Contributor

@nagix nagix commented Jun 6, 2019 •
edited by benmccann
Loading

When the dataset option xAxisID or yAxisID is changed and update() is called, it doesn't make any changes. This PR fixes it by modifying linkScales so that metadata is updated if dataset.xAxisID or dataset.yAxisID exists.

Master: https://jsfiddle.net/nagix/mwL6obck/
Screen Shot 2019-06-07 at 12 20 34 AM

This PR: https://jsfiddle.net/nagix/u7wta3ed/
Screen Shot 2019-06-07 at 12 21 02 AM

Fixes #6320

@benmccann benmccann changed the title Update dataset metadata when scaleID changes Update dataset metadata when axisID changes Jun 7, 2019
@benmccann
Copy link
Contributor

@nagix I updated the title and description from "scale" to "axis" to match the option name. Feel free to change back and let me know if I made a mistake

@nagix
Copy link
Contributor Author

nagix commented Jun 7, 2019

Thanks @benmccann, it looks good and correct🙂

@nagix nagix added the type: bug label Jun 7, 2019
@nagix nagix added this to the Version 2.9 milestone Jun 14, 2019
@nagix nagix merged commit 9eecdf4 into chartjs:master Jun 14, 2019
@nagix nagix deleted the issue-6321 branch June 15, 2019 09:48
charlesmass pushed a commit to charlesmass/Chart.js that referenced this pull request Jun 17, 2019
@nagix @charlesmass
Update dataset metadata when axisID changes (chartjs#6321)
03bfea8
@snyk-bot snyk-bot mentioned this pull request Nov 9, 2019
Merged
This was referenced Mar 4, 2020
Open
Open
@vpetersson vpetersson mentioned this pull request Mar 7, 2020
Merged
This was referenced Mar 9, 2020
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
This was referenced Apr 14, 2020
Open
Open
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
@nagix
Update dataset metadata when axisID changes (chartjs#6321)
046708c
This was referenced Jun 1, 2021
Closed
Merged
Closed
Open
Closed
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jul 5, 2021
Closed
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jul 5, 2021
Open
1 task
This was referenced Jul 27, 2021
Closed
Merged
Merged
This was referenced Oct 14, 2021
Merged
Closed
@jw jw mentioned this pull request Jan 17, 2022
Open
1 task
This was referenced Jan 21, 2022
Merged
Closed
This was referenced Feb 4, 2022
Closed
Closed
This was referenced Mar 7, 2022
Open
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Aug 13, 2022
Merged
1 task
This was referenced Nov 29, 2022
Closed
Closed
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jan 26, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

@etimberg etimberg etimberg approved these changes

@benmccann benmccann benmccann approved these changes

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
Version 2.9
Development

Successfully merging this pull request may close these issues.

Dataset is displayed on other scale than configured via axisID
4 participants
@nagix @benmccann @etimberg @kurkle