Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved code minimization #6362

Merged
merged 1 commit into from
Aug 13, 2019
Merged

Improved code minimization #6362

merged 1 commit into from
Aug 13, 2019

Conversation

benmccann
Copy link
Contributor

An assortment of random improvements I came across in the past couple days

etimberg
etimberg previously approved these changes Jun 29, 2019
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but not sure if _getLabels is right function to use.

@@ -60,7 +60,7 @@ module.exports = Scale.extend({
return me.getRightValue(chart.data.datasets[datasetIndex].data[index]);
}

return me.ticks[index - me.minIndex];
return me._getLabels()[index];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is altering of ticks in ticks.callback or afterBuildTicks supported?
me.getTicks()[index].label instead, in that case?

Copy link
Contributor Author

@benmccann benmccann Jul 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it wouldn't be supported because there's no other scale that accesses ticks in getLabelForIndex and this method is only used by the tooltip which a separate concept from ticks. The way we've always suggested customizing the tooltip is via https://www.chartjs.org/docs/latest/configuration/tooltip.html?q=#external-custom-tooltips

@benmccann
Copy link
Contributor Author

I've rebased this PR

@benmccann
Copy link
Contributor Author

@etimberg @nagix @kurkle any additional thoughts?

Copy link
Member

@etimberg etimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concerns other than @kurkle's comment. While we don't modify ticks in afterBuildTicks, it's possible that someone has. Not sure if that should block this, but we should be aware of it

@benmccann
Copy link
Contributor Author

benmccann commented Aug 8, 2019

@kurkle did my response address your concern or do you think I should change it back?

Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not assume that category scale is fed with only plain array data. So label index might not be same as data index. Anyway, its not what this PR is trying to do, so I think its fine for now.

@etimberg etimberg merged commit 4093483 into chartjs:master Aug 13, 2019
@simonbrunel
Copy link
Member

simonbrunel commented Aug 23, 2019

@benmccann @etimberg don't forget to rewrite the commit message when merging ("Minor cleanup" isn't helpful), but also add a label and milestone to every merged PR, it really helps to write release notes :)

@benmccann benmccann changed the title Minor cleanup Improved code minimization Aug 23, 2019
@benmccann
Copy link
Contributor Author

Ok. I've renamed to "Improved code minimization" which hopefully helps describe it a bit better

@simonbrunel
Copy link
Member

Thanks! we should make sure to rewrite the commit message (at least the commit title - first line) before merging so the git history (and blaming) contains more interesting information. infrastructure is everything related to CI/CD, scripts, gulp, npm, etc. but not changes in the code.

exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants