Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link back to home page from docs #6435

Merged
merged 3 commits into from
Aug 4, 2019
Merged

Conversation

jacobsorme
Copy link
Contributor

@jacobsorme jacobsorme commented Aug 4, 2019

Edited docs/SUMMARY.md to add the link - is that how the website is generated? See Issue #6433.

@jacobsorme jacobsorme changed the title Add link back to home page from docs #6433 Add link back to home page from docs Aug 4, 2019
etimberg
etimberg previously approved these changes Aug 4, 2019
@etimberg etimberg requested a review from benmccann August 4, 2019 14:04
docs/SUMMARY.md Outdated
@@ -1,5 +1,6 @@
# Summary

* [←](https://www.chartjs.org)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think might be slightly confusing because it looks like the back button and chartjs.org might not be the last page you visited.

A couple other options:

  • Rename the existing "Chart.js" link to "Introduction". Add a new link that says something like "Chart.js" or "Homepage"
  • Add a link to the samples instead. That's the only other thing that's on the homepage. It'd be fewer clicks that way because you could go straight to the samples instead of navigating through the homepage

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, you are right. I think both of your options make sense. If you somehow end up on docs without having been on the homepage before then the first option would make more sense. What do you think?

docs/SUMMARY.md Outdated
@@ -1,6 +1,7 @@
# Summary

* [Chart.js](README.md)
* [← Chart.js](https://www.chartjs.org)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably still drop the since it's a bit of an uncommon character

@etimberg etimberg merged commit 053729a into chartjs:master Aug 4, 2019
@simonbrunel simonbrunel added this to the Version 2.9 milestone Aug 23, 2019
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
* Add link back to home page from docs chartjs#6433

* Modify link texts

* Edit homepage link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants