Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assume time series data has been normalized #6775

Merged
merged 2 commits into from
Nov 23, 2019

Conversation

benmccann
Copy link
Contributor

An alternative to #6767 suggested in #6767 (comment)

@kurkle
Copy link
Member

kurkle commented Nov 21, 2019

Although this could be more limited, I like this better - mainly because it only helps the "split of time scale" I've been thinking about.

This probably is good enough for your use cases?

Actually. I think the more complex cases, where some series might miss some values, but we know the dates we want to plot (without the weekends) - can be achieved by something like (options might be at wrong locations):

data: {
  labels: [all the ones we want]
  datasets: [{data: [{x,y}]]
},
options: {
  scales: {
    x: {
      type: 'time',
      distribution: 'series'
      ticks: {
        source: 'labels',
    }
  }
}

@kurkle
Copy link
Member

kurkle commented Nov 21, 2019

Changes look fine to me, but I think some documentation should be added.

@benmccann
Copy link
Contributor Author

Ok, I added a sentance to the docs. Let me know if it's what you had in mind

@benmccann benmccann closed this Nov 23, 2019
@benmccann benmccann reopened this Nov 23, 2019
@benmccann
Copy link
Contributor Author

@etimberg I closed and reopened this PR to kick off the build again, so the tests are passing now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants