Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable override settings for the axis border #6883

Merged
merged 2 commits into from
Jan 3, 2020

Conversation

etimberg
Copy link
Member

@etimberg etimberg commented Dec 31, 2019

Adds two new options to the cartesian axis: borderColor and borderWidth which are used to control the border drawn at the edge of the axis area. If these options are not set, the first grid line settings are used.

Closes: #4041

Adds two new options to the cartesian axis: `borderColor` and `borderWidth`
which are used to control the border drawn at the edge of the axis area.
If these options are not set, the first grid line settings are used.
@etimberg etimberg added this to the Version 3.0 milestone Dec 31, 2019
Copy link
Contributor

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a new option or just suggest to people to use scriptable options? I'm not sure how to think about the tradeoff

docs/axes/styling.md Outdated Show resolved Hide resolved
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than "colour", looks good to me

@kurkle kurkle changed the title Enable override settings for the axis border - #4041 Enable override settings for the axis border Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coloring an axis line separately from gridLines
3 participants