Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default beginAtZero to true for linear axes #6914

Closed
wants to merge 1 commit into from

Conversation

etimberg
Copy link
Member

@etimberg etimberg commented Jan 5, 2020

Resolves #5939

@etimberg etimberg added this to the Version 3.0 milestone Jan 5, 2020
@benmccann
Copy link
Contributor

grep -r beginAtZero docs/ - there's a handful of docs that can be updated. E.g. mentioning the default value for beginAtZero and some that specify beginAtZero: true which is no longer required

@benmccann
Copy link
Contributor

There's a handful of samples where it'd no longer be required as well

@benmccann
Copy link
Contributor

Also, I've been thinking that rather than setting this for the linear scale generally we should set it just for bar charts. If you look at the two articles in the original bug report they give a good explanation of why it's desired for bar charts and not line charts. Also, one of the issues this fixes is that the lowest bar disappears on the bar chart by default, but that's only an issue for bars

@etimberg
Copy link
Member Author

etimberg commented Jan 5, 2020

I’d be open to just doing it for bar charts. That would revert most of these changes. I’ll close this and open another PR

@kurkle
Copy link
Member

kurkle commented Jan 5, 2020

I vote for the "just for bar charts"

@etimberg etimberg closed this Jan 5, 2020
@etimberg etimberg deleted the default-begin-at-zero-true branch January 5, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change scale.beginAtZero default to true
3 participants