Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tooltip docs with working example #6918

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Update tooltip docs with working example #6918

merged 1 commit into from
Jan 6, 2020

Conversation

etimberg
Copy link
Member

@etimberg etimberg commented Jan 5, 2020

Resolves #6216

@etimberg etimberg added this to the Version 3.0 milestone Jan 5, 2020
benmccann
benmccann approved these changes Jan 5, 2020
View reviewed changes
Copy link
Contributor

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, but I don't see what was wrong with the old one

@etimberg
Copy link
Member Author

etimberg commented Jan 5, 2020

#6216 complained that it didn't work. I don't know how true that was in v2.9.x, but in v3 it was using the old yLabel property that no longer exists on the TooltipItem

@benmccann
Copy link
Contributor

When I look at the diff I don't see yLabel?

@etimberg
Copy link
Member Author

etimberg commented Jan 6, 2020

I must have had an old copy locally when I started

@etimberg etimberg merged commit 895e746 into chartjs:master Jan 6, 2020
@etimberg etimberg deleted the improve-docs-tooltip-example branch January 6, 2020 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

@benmccann benmccann benmccann approved these changes

Assignees
No one assigned
Labels
type: documentation
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.

Not clear how to override the default tooltip
3 participants
@etimberg @benmccann @kurkle