Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit interactions to chartArea (+/-0.5px) #6943

Merged
merged 4 commits into from
Jan 11, 2020
Merged

Limit interactions to chartArea (+/-0.5px) #6943

merged 4 commits into from
Jan 11, 2020

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Jan 9, 2020

  • horizontalBar, beginAtZero true by default. So getCenterPoint returns a point in chartArea for tests. (Also for consistency with bar)
  • Remove _lastActive from tooltip, its not used for anything.
  • Change epsilon to 0.5 so rounded points match decimals. Some tests use whole numbers, didn't investigate further.

Fixes: #6931

@kurkle
Copy link
Member Author

kurkle commented Jan 9, 2020

Event coordinates seem to be flanky. I'll give this one more try tomorrow.

@etimberg etimberg merged commit f1677b6 into chartjs:master Jan 11, 2020
@kurkle kurkle deleted the interactions-chore branch February 19, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@benmccann benmccann benmccann approved these changes

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ChartJS - tooltip shows on the label
3 participants
@kurkle @benmccann @etimberg