fix drawPoint parameters #6975
Merged
fix drawPoint parameters #6975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
previously approved these changes
Jan 17, 2020
kurkle
previously approved these changes
Jan 17, 2020
etimberg
previously approved these changes
Jan 18, 2020
|
Looks like the test failures may be real |
|
I doubt the test failures are real because all the tests passed on GitHub Actions. I'll close and reopen to kick off Travis again. For reference, here are the errors:
|
benmccann
approved these changes
Jan 18, 2020
kurkle
approved these changes
Jan 18, 2020
etimberg
approved these changes
Jan 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legend plugin was not using the latest method signature for drawPoint which is (context, options, x, y). This has been fixed here, so usePointStyle parameter is now working again for legend.