Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in opacity handling #7047

Merged
merged 1 commit into from
Feb 1, 2020
Merged

Fix bug in opacity handling #7047

merged 1 commit into from
Feb 1, 2020

Conversation

benmccann
Copy link
Contributor

TypeScript for the win!

@benmccann benmccann mentioned this pull request Feb 1, 2020
Merged
kurkle
kurkle approved these changes Feb 1, 2020
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comes all the way from the original merge: #1688
I'm wondering why that issue has not been reported again.

@etimberg etimberg merged commit 26536f8 into chartjs:master Feb 1, 2020
@etimberg etimberg added this to the Version 3.0 milestone Feb 1, 2020
@benmccann
Copy link
Contributor Author

I think it hasn't been reported because the effect is basically that it will never clamp, which isn't a terrible way to fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

@etimberg etimberg etimberg approved these changes

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@benmccann @etimberg @kurkle