Configurable hide/show animations #7055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etimberg
reviewed
Feb 4, 2020
benmccann
reviewed
Feb 4, 2020
src/core/core.controller.js
Outdated
| me.setDataVisibility(datasetIndex, index, visible); | ||
| } | ||
| meta._skipUpdate = true; | ||
| me.update(); |
There was a problem hiding this comment.
Why don't we just not call update instead of adding _skipUpdate?
There was a problem hiding this comment.
Added some comments to explain
There was a problem hiding this comment.
It feels a little off to me that we're reaching inside the meta object to set a private property _skipUpdate. E.g. it's not an API our users would be able to use really. What do you think about if we made mode also able to take a function to be resolved and then we could return a different mode for datasetIndex?
etimberg
previously approved these changes
Feb 4, 2020
|
rebased |
etimberg
previously approved these changes
Feb 5, 2020
etimberg
previously approved these changes
Feb 5, 2020
etimberg
previously approved these changes
Feb 6, 2020
|
@kurkle looks like this one needs to be rebased |
etimberg
approved these changes
Feb 6, 2020
benmccann
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1833
master:
pr:
