Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix function support on _fallback #8545

Merged
merged 1 commit into from
Mar 1, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/helpers/helpers.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -245,14 +245,15 @@ function resolveFallback(fallback, prop, value) {
return isFunction(fallback) ? fallback(prop, value) : fallback;
}

const getScope = (key, parent) => key === true ? parent : resolveObjectKey(parent, key);
const getScope = (key, parent) => key === true ? parent
: typeof key === 'string' ? resolveObjectKey(parent, key) : undefined;

function addScopes(set, parentScopes, key, parentFallback) {
for (const parent of parentScopes) {
const scope = getScope(key, parent);
if (scope) {
set.add(scope);
const fallback = scope._fallback;
const fallback = resolveFallback(scope._fallback, key, scope);
if (defined(fallback) && fallback !== key && fallback !== parentFallback) {
// When we reach the descriptor that defines a new _fallback, return that.
// The fallback will resume to that new scope.
Expand Down
31 changes: 31 additions & 0 deletions test/specs/helpers.config.tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,37 @@ describe('Chart.helpers.config', function() {
});
});

it('should support _fallback as function', function() {
const descriptors = {
_fallback: (prop, value) => prop === 'hover' && value.shouldFall && 'interaction',
};
const defaults = {
interaction: {
mode: 'test',
priority: 'fall'
},
hover: {
priority: 'main'
}
};
const options = {
interaction: {
a: 1
},
hover: {
shouldFall: true,
b: 2
}
};
const resolver = _createResolver([options, defaults, descriptors]);
expect(resolver.hover).toEqualOptions({
mode: 'test',
priority: 'main',
a: 1,
b: 2
});
});

it('should not fallback by default', function() {
const defaults = {
hover: {
Expand Down