Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix object notation border width barchart #9800

Merged
merged 3 commits into from
Oct 26, 2021
Merged

Fix object notation border width barchart #9800

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d51990d
make object available for bar as border Radius
LeeLenaleee Oct 26, 2021
609d047
override only the bar borderWidth prop
LeeLenaleee Oct 26, 2021
46fcf47
spacing
LeeLenaleee Oct 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion types/index.esm.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1908,7 +1908,7 @@ export interface BarProps {
height: number;
}

export interface BarOptions extends CommonElementOptions {
export interface BarOptions extends Omit<CommonElementOptions, 'borderWidth'> {
/**
* The base value for the bar in data units along the value axis.
*/
Expand All @@ -1932,6 +1932,12 @@ export interface BarOptions extends CommonElementOptions {
* @default 'auto'
*/
inflateAmount: number | 'auto';

/**
* Width of the border, number for all sides, object to specify width for each side specifically
* @default 0
*/
borderWidth: number | { top?: number, right?: number, bottom?: number, left?: number };
}

export interface BorderRadius {
Expand Down