add beforeDestroy hook

[LeeLenaleee]

Resolves #9931

[kurkle]

Should add to documentation.

[LeeLenaleee]

Thats what I thought but when I looked at the plugins hook section it only showed render diagrams for the inialization, update, render and event prosses.

Did I miss a place in the docs where all the hooks get described because I couldnt find it, also not with the search bar?

Or do you suggest adding an extra diagram for destroying the chart on that plugin section?

[stockiNail]

@LeeLenaleee let me ask you if makes sense to you to change also the destroy hook in afterDestroy (of course moving the notification after delete of instance). Maybe in this way it could be consistent with the other plugin hooks.
But I know, this would be a breaking change.

[stockiNail]

Did I miss a place in the docs where all the hooks get described because I couldnt find it, also not with the search bar?

docs/developers

docs/developers/plugin_flowcharts.drawio

[LeeLenaleee]

@LeeLenaleee let me ask you if makes sense to you to change also the destroy hook in afterDestroy (of course moving the notification after delete of instance). Maybe in this way it could be consistent with the other plugin hooks.
But I know, this would be a breaking change.

Yeah this does indeed make sense because it happens after the destroy and would be more in line with the current naming of hooks. But like you said this will be a breaking change so best thing to do I think is make a new issue for this to rename it and target v4 with it.

docs/developers/plugin_flowcharts.drawio

Thanks, means I didnt miss a spot. The uninstall prosess was not being described but I will make a flow for that one and add it 👍

[kurkle]

We could add the afterDestroy already and leave the destroy hook to be removed in V4.
@etimberg thoughts?

[etimberg]

That works for me. We can just deprecate the destroy hook but leave it in until v4

[LeeLenaleee]

I saw that the destroy hook was called before the deletion of the chart instance from the instances object. Shouldnt the destroy and afterDestroy hooks be called after this deletion happend at the very end of the destroy function?

FlowChart:

[stockiNail]

Shouldnt the destroy and afterDestroy hooks be called after this deletion happend at the very end of the destroy function?

As user, I'd expect after the deletion from the instances. But this is just my personal opinion.

[kurkle]

Notify stop two times in the flow chart

[LeeLenaleee]

Seems I coppied the flow diagram in wrong state, current code had correct version: