Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix animations #36

Merged
merged 1 commit into from
May 25, 2018
Merged

Fix animations #36

merged 1 commit into from
May 25, 2018

Conversation

Jark
Copy link
Contributor

@Jark Jark commented May 25, 2018

Thanks for contributing.

Description

Chart.js only animates the direct properties of the view model, so I've changed candle.h into candleHeight for the vm so Chart.js can animate the properties properly.

Testing

I've updated the existing unit test and added a new button "Randomize data" to the test page.

Here's the result:

f00b73dd-bc4c-4a2e-9684-c08939caed30

@benmccann benmccann merged commit 523302c into chartjs:master May 25, 2018
@benmccann
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants