Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #61 Error: Cannot find module 'rollup/bin/rollup' #62

Merged
merged 1 commit into from
Oct 9, 2019

Conversation

andrericardo
Copy link
Contributor

@andrericardo andrericardo commented Oct 8, 2019

Based on bin path in https://github.com/chartjs/Chart.js/blob/master/gulpfile.js

Thanks for contributing.

Description

Changed the path of rollup

PS: I've only just noticed that this is also failing master in Travis after the version bump commit
https://travis-ci.org/chartjs/chartjs-chart-financial/builds/591814183#L498

Testing

Sorry I don't know yet how to test a gulp file method properly, here is a screenshot of the build working.
Screen Shot 2019-10-09 at 00 43 57

The error
Screen Shot 2019-10-09 at 00 45 53

gulp build

[00:45:51] Using gulpfile ~/VirtualBox/Win10/chartjs-chart-financial/gulpfile.js
[00:45:51] Starting 'build'...
[00:45:51] Starting 'rollupTask'...
[00:45:51] 'rollupTask' errored after 4.01 ms
[00:45:51] Error: Cannot find module 'rollup/bin/rollup'
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:613:15)
at Function.resolve (internal/modules/cjs/helpers.js:28:19)
at run (/Users/andre/VirtualBox/Win10/chartjs-chart-financial/gulpfile.js:42:21)
at rollupTask (/Users/andre/VirtualBox/Win10/chartjs-chart-financial/gulpfile.js:51:3)
at bound (domain.js:400:14)
at runBound (domain.js:413:12)
at asyncRunner (/Users/andre/VirtualBox/Win10/chartjs-chart-financial/node_modules/async-done/index.js:55:18)
at processTicksAndRejections (internal/process/next_tick.js:74:9)
[00:45:51] 'build' errored after 10 ms

@benmccann benmccann merged commit 41ef47e into chartjs:master Oct 9, 2019
@andrericardo andrericardo deleted the rollup-error-61 branch October 9, 2019 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants