Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add polyfill for Luxon for example to work in IE11 #64

Merged
merged 1 commit into from
Oct 9, 2019

Conversation

andrericardo
Copy link
Contributor

@andrericardo andrericardo commented Oct 9, 2019

Description

Not sure if IE11 support is desired but this changes the examples to work with IE11.
Uses Moment.js for the examples in the docs rather than Luxon.

Related #60

Testing

Working with IE11, ran gulp test, if there are any articles on how to add tests according to what you want can you please let me know?
Screen Shot 2019-10-09 at 11 22 00

@benmccann benmccann force-pushed the master branch 2 times, most recently from 9580342 to 9bf4ed7 Compare October 9, 2019 15:50
@benmccann
Copy link
Collaborator

I think I'd probably rather not switch the example because Luxon has better support for i18n and timezones, which I care about more for my own use case than IE11 support. I've added some information about date libraries to the README though. Hopefully that will help others who run into this issue

@andrericardo andrericardo force-pushed the change-examples-work-IE11 branch from 6b8dc2c to dca982a Compare October 9, 2019 16:17
@andrericardo
Copy link
Contributor Author

Makes sense, would you consider adding the polyfill to example instead? I've managed to get it working with Luxon using the polyfill in IE11, updating the PR.

Screen Shot 2019-10-09 at 17 16 04

@andrericardo andrericardo changed the title Use Moment rather than Luxon for example to work in IE11 Add polyfill for Luxon for example to work in IE11 Oct 9, 2019
@benmccann benmccann merged commit 6bed92f into chartjs:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants