Updated to Chart.js v3.0.0-beta.3 #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm on my phone so can't quite tell, but it looks like you may have changed the tabs indentation to spaces. If so could you please change it back? |
|
Sorry, not sure what's going on but eslint rules behave differently on my local machine than on travis 🤷♂️ |
benmccann
reviewed
Oct 12, 2020
benmccann
reviewed
Oct 12, 2020
benmccann
reviewed
Oct 12, 2020
|
@benmccann would you be open to release this as a beta/with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing.
Description
Updated code to function correctly when using latest chart.js 3.0.0-beta.3
Testing
Tested including the updated library in ng2-charts: valor-software/ng2-charts#1276