fix: Set local directory perms to 774 #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support using securityContext.fsGroup to RW charts to a filesystem, we can create the directories with 774 permissions. We have to use os.Chmod in order to set the correct perms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes helm/chartmuseum#524.
In order to support using
securityContext.fsGroupto allow reading/writing charts to a directory on an NFS for example and not setting the owner to1000(to limit other users with that UID from having access), we can create the directories with774permissions. But we have to useos.Chmodin order to set the correct perms due toos.MkdirAllapplying permissions before the umask (defaults directory permissions to755).@jdolitsky Based on the code, the intention here was to set the directory permissions to
777. I could keep that permission level and just apply theos.Chmodwith that but I think denyingothersto write to the chart directory seems desirable. what do you think? There might be some context I'm missing here 👀