Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: take locale on hook, use custom dictionary #172

Merged
merged 2 commits into from
Jun 21, 2024
Merged

fix: take locale on hook, use custom dictionary #172

merged 2 commits into from
Jun 21, 2024

Conversation

hmbanan666
Copy link
Collaborator

@hmbanan666 hmbanan666 commented Jun 21, 2024

Не вижу смысла реализовывать локализацию на стороне клиента.

  • Кастомные словари с поддержкой типов
  • Server Hook сразу определяет необходимую locale, записывает в App.locals, делает редирект при необходимости
  • Меняем URL: https://chatgame.space/[locale]/...

@hywax
Copy link
Contributor

hywax commented Jun 21, 2024

Ну такой вариант тоже подходит, так наверное даже лучше будет

@hmbanan666 hmbanan666 self-assigned this Jun 21, 2024
@hmbanan666 hmbanan666 merged commit 070b30c into main Jun 21, 2024
1 check passed
@hmbanan666 hmbanan666 deleted the fix-i18n branch June 21, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants