chatmail user can't add relay

[adbenitez]

an user reported to me they can't add relay due to "display classic email" option, this option is not even visible, it will be better to just remove this option and avoid having to workaround it in the UI, since we want to get rid of is_chatmail it doesn't make sense to add more code in the UI that depends on this setting

[link2xt]

The issue here is that the user somehow managed to set the setting to non-default value, but UI hides the setting now. It could be is_chatmail was not set previously, either because the setting was not there, or because the profile started with a non-chatmail server and it was added later.

it will be better to just remove this option and avoid having to workaround it in the UI, since we want to get rid of is_chatmail it doesn't make sense to add more code in the UI that depends on this setting

UI code to hide the setting is already there, if you hide the setting you can as well reset it in the same place.

There are also other settings UI hides that are currently in the "Legacy options", like mvbox_move, they have the same problem. There is currently no plan on when to remove them.

[adbenitez]

this can't be done in the same place where the setting is hidden, that is only done when the user opens the advanced settings screen, this would require yet another migration checking is_chatmail in ApplicationContext, no need to keep adding more, when there is a bug at hand it is clear when is the plan to remove this particular option: when you want to fix this bug

at the very least, the option could be automatically set back to "all" when the user calls "add relay" api, instead of showing this error dialog, and making user do it manually, that wouldn't require removing anything

[raffle1045]

The issue here is that the user somehow managed to set the setting to non-default value, but UI hides the setting now. It could be is_chatmail was not set previously, either because the setting was not there, or because the profile started with a non-chatmail server and it was added later.

Hello! I'm the chatmail user that reported the issue to adb.

As I told adb, the profile in question that was having issue adding additional chatmail relays is not a classic email account but rather a chatmail profile on nine.testrun.org. Which certainly left me confused as to why it happened.

I can provide a log if you'd like.