Skip to content

be more tolerant on webrtc-servers set by the user #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 18, 2020
Merged

Conversation

r10s
Copy link
Contributor

@r10s r10s commented Aug 13, 2020

this pr adds more tolerance to webrtc-servers as specified via set_config("webrtc_instance") - which is settable directly from the uis.

  • if reasonable, missing slashes are added to the specified servers
  • the protocol may be left out, in this case, https:// is added

so, you can use jitsi by just typing meet.jit.si instead of https://meet.jit.si/

fixes #1830

@r10s r10s changed the title be more tolerant on set webrtc-servers be more tolerant on webrtc-servers set by the user Aug 13, 2020
@r10s
Copy link
Contributor Author

r10s commented Aug 15, 2020

ci seems to be broken, maybe because of rust-lang/rust#64496

Copy link
Collaborator

@Hocuri Hocuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@r10s r10s merged commit d26347a into master Aug 18, 2020
@r10s r10s deleted the trailing-slash branch August 18, 2020 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misbuilt URL to video chat server session, misses slash
3 participants