Don't degrade encryption when MDN is received#5152
Merged
Conversation
link2xt
force-pushed
the
link2xt/read-receipt-dont-degrade-encryption
branch
2 times, most recently
from
e8bcff6 to
5818463
Compare
iequidoo
approved these changes
Jan 5, 2024
Collaborator
iequidoo
left a comment
iequidoo
left a comment
There was a problem hiding this comment.
Maybe it would be nice to have a Rust test on the MDN structure also
This is broken since 44227d7 mimeparser only recognizes read receipts by the Content-Type being "multipart/report". If multipart/report is hidden inside multipart/mixed and the message is not encrypted, it degrades encryption.
link2xt
force-pushed
the
link2xt/read-receipt-dont-degrade-encryption
branch
from
5818463 to
3bcdd17
Compare
Septias
added a commit
that referenced
this pull request
Jan 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed MDN structure to have
multipart/reporton the outer side and added regression test.Fixes #5150
Fixes #5151