fix: Save QR code token regardless of whether the group exists (#5954)#5956
Merged
fix: Save QR code token regardless of whether the group exists (#5954)#5956
Conversation
iequidoo
force-pushed
the
iequidoo/async-qr-code-tokens
branch
from
e874df1 to
bd2a446
Compare
iequidoo
changed the title
iequidoo
force-pushed
the
iequidoo/async-qr-code-tokens
branch
from
bd2a446 to
3fd4596
Compare
iequidoo
commented
Sep 6, 2024
iequidoo
commented
Sep 6, 2024
iequidoo
force-pushed
the
iequidoo/async-qr-code-tokens
branch
4 times, most recently
from
cd83bc9 to
bff4a09
Compare
link2xt
reviewed
Sep 10, 2024
iequidoo
force-pushed
the
iequidoo/async-qr-code-tokens
branch
from
bff4a09 to
a1f289a
Compare
link2xt
reviewed
Sep 11, 2024
iequidoo
force-pushed
the
iequidoo/async-qr-code-tokens
branch
from
a1f289a to
2e59700
Compare
iequidoo
force-pushed
the
iequidoo/async-qr-code-tokens
branch
from
2e59700 to
d90476e
Compare
link2xt
reviewed
Sep 15, 2024
Groups promotion to other devices and QR code tokens synchronisation are not synchronised processes, so there are reasons why a QR code token may arrive earlier than the first group message: - We are going to upload sync messages via IMAP while group messages are sent by SMTP. - If sync messages go to the mvbox, they can be fetched earlier than group messages from Inbox.
iequidoo
force-pushed
the
iequidoo/async-qr-code-tokens
branch
from
d90476e to
50d2386
Compare
link2xt
approved these changes
Sep 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groups promotion to other devices and QR code tokens synchronisation are not synchronised processes, so there are reasons why a QR code token may arrive earlier than the first group message:
Fix #5954
TODO(done): Test. I think that
test_securejoin.py:test_qr_securejoin()may be left unmodified, it's very unlikely that thealice2device won't receive the QR code token by the moment Fiona joins (moreover, Alice doesn't have the mvbox in this test). But a new test checking that QR code tokens are saved if arrive earlier than first group messages is needed. EDIT:sync::test_unpromoted_group_qr_sync()tests this now.